Add check for go mod tidy #77
Merged
+10
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jbw976 Here you go! Could you please approve running the pipeline 😄 |
Contributor
Author
|
@jbw976 looks good to merge IMHO |
Contributor
Author
|
@jbw976 hey, anything holding this up? |
Moulick
force-pushed
the
main
branch
2 times, most recently
from
cd91012 to
ad09846
Compare
Contributor
Author
|
So looks like the |
Member
|
Hi @Moulick thanks a lot for your contribution! Do you mind rebasing the PR? |
Contributor
Author
|
@ezgidemirel Done, could you please run the CI again? |
Add a step to check for go mod tidy in the CI workflow. Also configure renovate to run go mod tidy when bumping dependencies. Signed-off-by: Moulick Aggarwal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
ref: crossplane-contrib/function-go-templating#105 (comment)
go mod tidyto remove unused dependencies. This is generally a good practice and results in faster downloads/less cache.go mod tidywhenever it upgrades a dependency.I have:
go test ./...